Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

U256 type does not support num_traits::int::PrimInt #714

Closed
gilescope opened this issue Jan 26, 2023 · 3 comments
Closed

U256 type does not support num_traits::int::PrimInt #714

gilescope opened this issue Jan 26, 2023 · 3 comments

Comments

@gilescope
Copy link
Contributor

and so IntegerSqrt is not supported. integer-sqrt has a blanket impl for anything that supports the num_traits::PrimInt.

https://crates.io/crates/integer-sqrt
@ordian
Copy link
Member

ordian commented Jan 29, 2023

I've implemented integer_sqrt as an inherent method, because the one provided by the crate is slow
#554

@gilescope
Copy link
Contributor Author

Nice - should have spotted that feature. Now I just need to get checked add / mul / div / sub supported for U256.

@gilescope
Copy link
Contributor Author

This should cover it: #716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gilescope @ordian