-
Notifications
You must be signed in to change notification settings - Fork 234
add H384
and H768
hash types
#684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know much about BLS12-377, but code changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing impls for num-traits
,impl-serde
, impl-codec
, impl-rlp
as well as convertions from other smaller types and to larger types (see the file below).
These hash types are needed to be able to hash to the base fields of group G1 and G2 of BLS12-377 and BLS12-381 curves. BLS12-377 is going to be used in BEEFY Messages for the ultra light client.