Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add H384 and H768 hash types #684

Merged
merged 4 commits into from Oct 27, 2022
Merged

add H384 and H768 hash types #684

merged 4 commits into from Oct 27, 2022

Conversation

drskalman
Copy link
Contributor

These hash types are needed to be able to hash to the base fields of group G1 and G2 of BLS12-377 and BLS12-381 curves. BLS12-377 is going to be used in BEEFY Messages for the ultra light client.

acatangiu
acatangiu approved these changes Oct 18, 2022
View reviewed changes
Copy link

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

svyatonik
svyatonik approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know much about BLS12-377, but code changes LGTM

ordian
ordian requested changes Oct 18, 2022
View reviewed changes
Copy link
Member

@ordian ordian left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing impls for num-traits, impl-serde, impl-codec, impl-rlp as well as convertions from other smaller types and to larger types (see the file below).

@drskalman drskalman requested review from ordian and removed request for andresilva October 27, 2022 07:16
@ordian ordian merged commit 26c1423 into paritytech:master Oct 27, 2022
@ordian ordian added the changelog Needs to be added to the changelog label Oct 27, 2022
@ordian ordian mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svyatonik svyatonik svyatonik approved these changes

@ordian ordian ordian approved these changes

@serban300 serban300 serban300 approved these changes

@acatangiu acatangiu acatangiu approved these changes

Assignees
No one assigned
Labels
changelog Needs to be added to the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@drskalman @svyatonik @ordian @serban300 @acatangiu