Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethereum-types: add if_ethbloom conditional macro #682

Merged
merged 1 commit into from Sep 30, 2022
Merged

ethereum-types: add if_ethbloom conditional macro #682

merged 1 commit into from Sep 30, 2022

Conversation

vorot93
Copy link
Contributor

@vorot93 vorot93 commented Sep 28, 2022

In the spirit of serde's serde_if_integer128.

ordian
ordian approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is sensible.

@ordian ordian added the changelog Needs to be added to the changelog label Sep 30, 2022
@ordian ordian merged commit baebea7 into paritytech:master Sep 30, 2022
@vorot93 vorot93 deleted the if-ethbloom branch December 3, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ordian ordian ordian approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
changelog Needs to be added to the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vorot93 @ordian @niklasad1