add to kvdb-rocksdb create_if_missing config option

[debris]

will be used to implement "auto backend" paritytech/substrate#9201

changes:

• add to kvdb-rocksdb create_if_missing config option
• add #[non_exhaustive] above the DatabaseConfig

[ordian]

Could you also put #[non_exhaustive] above DatabaseConfig and update the changelog?
https://rust-lang.github.io/rfcs/2008-non-exhaustive.html#structs-1

[debris]

Could you also put #[non_exhaustive] above DatabaseConfig and update the changelog?
https://rust-lang.github.io/rfcs/2008-non-exhaustive.html#structs-1

Thanks for the link @ordian I didn't know about this. However this will prevent downstream users from constructing or exhaustively matching the struct. Is it the intended behaviour?

[ordian]

Could you also put #[non_exhaustive] above DatabaseConfig and update the changelog?
https://rust-lang.github.io/rfcs/2008-non-exhaustive.html#structs-1

Thanks for the link @ordian I didn't know about this. However this will prevent downstream users from constructing or exhaustively matching the struct. Is it the intended behaviour?

They can construct it with

let mut config = DatabaseConfig::default();
config.create_if_missing = false;

and exhaustive matching is disallowed. The intention is to allow adding more fields w/o making a breaking change.

[ordian]

Published