uint: implement integer_sqrt #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xlc are you OK with |
|
|
dvdplm
reviewed
Jun 29, 2021
| @@ -9,4 +9,5 @@ edition = "2018" | |||
|
|
|||
| [dependencies] | |||
| num-traits = { version = "0.2", default-features = false } | |||
| integer-sqrt = "0.1" | |||
There was a problem hiding this comment.
So this is independent of the num-traits feature?
There was a problem hiding this comment.
Technically it could have been, but it's rather not useful by its own. E.g. see https://github.com/paritytech/substrate/blob/d8b3fce28513169d8ee1315dd9a4cd92d95753cc/primitives/arithmetic/src/traits.rs#L33-L51
dvdplm
approved these changes
Jun 29, 2021
sorpaas
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #551.
The algorithm implemented is the same as in theinteger-sqrtcrate and it's quite slow, on my machine u256 isqrt takes 2μs (>2000ns) and u512 > 5μs.Do you know of any better algorithms?