Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[triehash] Migrate to 2018 edition #214

Merged
merged 6 commits into from
Sep 5, 2019
Merged

[triehash] Migrate to 2018 edition #214

merged 6 commits into from
Sep 5, 2019

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Sep 4, 2019 •
edited

Signed-off-by: koushiro koushiro.cqx@gmail.com

What I have changed

@koushiro
Migrate triehash to 2018 edition
bef1c9f 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro
Update travis ci config
d1ec626 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@ordian ordian requested a review from dvdplm September 4, 2019 11:05
niklasad1
niklasad1 reviewed Sep 4, 2019
View reviewed changes
triehash/src/lib.rs Outdated Show resolved Hide resolved
dvdplm
dvdplm suggested changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just revert the changes to the CI script.

.travis.yml Outdated Show resolved Hide resolved
@koushiro
Revert ci config
64abb74 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro
Merge remote-tracking branch 'upstream/master' into triehash
4f8223f 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@dvdplm dvdplm merged commit d272425 into paritytech:master Sep 5, 2019
@koushiro koushiro deleted the triehash branch September 6, 2019 02:36
ordian pushed a commit that referenced this pull request Sep 6, 2019
Merge branch 'master' into ao-kvdb-indexeddb
1e89da3 
* master:
  [triehash] Migrate to 2018 edition (#214)
  [rlp] Add no_std support  (#206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 left review comments

@dvdplm dvdplm dvdplm approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A8-looksgood
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@koushiro @dvdplm @ordian @niklasad1