Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GRANDPA call limits verification to the relayer code #2982

Closed
svyatonik opened this issue May 6, 2024 · 1 comment · Fixed by paritytech/polkadot-sdk#4549
Closed

Add GRANDPA call limits verification to the relayer code #2982

svyatonik opened this issue May 6, 2024 · 1 comment · Fixed by paritytech/polkadot-sdk#4549
Labels
P-Relay

Comments

@svyatonik
Copy link
Contributor

See paritytech/polkadot-sdk#4385 - it is better to have a relayer that is smart enough to do this check offchain. So let's update relayer at least. We then may consider removal of this check from the onchain code
@svyatonik
Copy link
Contributor Author

Also this: #2730

@svyatonik svyatonik mentioned this issue May 23, 2024
Merged
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this issue May 27, 2024
@svyatonik
Bridge: check submit_finality_proof limits before submission (#4549)
f6cca7e 
closes paritytech/parity-bridges-common#2982
closes paritytech/parity-bridges-common#2730

The main change is in the
bridges/relays/lib-substrate-relay/src/finality/target.rs, changes in
other files are just moving the code

~I haven't been able to run zn tests locally - don't know why, but it
keeps failing for me locally with: `
Error running script:
/home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
Error: Timeout(300), "custom-js
/home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
within 300 secs" didn't complete on time.`~ The issue was an obsolete
`polkadot-js-api` binary - did `yarn global upgrade` and it is ok now
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this issue May 27, 2024
@svyatonik @TomaszWaszczyk
Bridge: check submit_finality_proof limits before submission (parityt…
8d14574 
…ech#4549)

closes paritytech/parity-bridges-common#2982
closes paritytech/parity-bridges-common#2730

The main change is in the
bridges/relays/lib-substrate-relay/src/finality/target.rs, changes in
other files are just moving the code

~I haven't been able to run zn tests locally - don't know why, but it
keeps failing for me locally with: `
Error running script:
/home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
Error: Timeout(300), "custom-js
/home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
within 300 secs" didn't complete on time.`~ The issue was an obsolete
`polkadot-js-api` binary - did `yarn global upgrade` and it is ok now
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this issue Jun 5, 2024
@svyatonik @hitchhooker
Bridge: check submit_finality_proof limits before submission (parityt…
e629d5a 
…ech#4549)

closes paritytech/parity-bridges-common#2982
closes paritytech/parity-bridges-common#2730

The main change is in the
bridges/relays/lib-substrate-relay/src/finality/target.rs, changes in
other files are just moving the code

~I haven't been able to run zn tests locally - don't know why, but it
keeps failing for me locally with: `
Error running script:
/home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
Error: Timeout(300), "custom-js
/home/svyatonik/dev/polkadot-sdk/bridges/testing/framework/js-helpers/wait-hrmp-channel-opened.js
within 300 secs" didn't complete on time.`~ The issue was an obsolete
`polkadot-js-api` binary - did `yarn global upgrade` and it is ok now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-Relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bridge: check submit_finality_proof limits before submission paritytech/polkadot-sdk
1 participant
@svyatonik