Add clippy to CI and fix several clippy warnings #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chevdor
force-pushed
the
wk-clippy-fixes
branch
from
2b33a12
to
201989a
Compare
tomusdrw
approved these changes
Apr 20, 2021
tomusdrw
approved these changes
Apr 21, 2021
dvdplm
approved these changes
Apr 21, 2021
niklasad1
reviewed
Apr 22, 2021
| @@ -71,7 +71,7 @@ impl RpcMethodAttribute { | |||
| fn parse_meta(attr: &syn::Attribute, output: &syn::ReturnType) -> Option<Result<RpcMethodAttribute>> { | |||
| match attr.parse_meta().and_then(validate_attribute_meta) { | |||
| Ok(ref meta) => { | |||
| let attr_kind = match path_to_str(meta.path()).as_ref().map(String::as_str) { | |||
| let attr_kind = match path_to_str(meta.path()).as_deref() { | |||
niklasad1
reviewed
Apr 22, 2021
| }; | ||
| if ident.to_string() == "Self" { | ||
| let syn::PathSegment { ident, .. } = &segments[0]; | ||
| let ident = ident; |
There was a problem hiding this comment.
why this additional let binding?
niklasad1
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add running clippy right after rustfmt during the CI.
It also fixes many warnings (many being due to mix of spaces and tabs in the doc examples).