Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to edition 2018 #368

Merged
merged 31 commits into from Jan 29, 2019
Merged

Migrate to edition 2018 #368

merged 31 commits into from Jan 29, 2019

Conversation

ascjones
Copy link
Member

Closes #360.

On each crate:

  • ran cargo fix --edition --allow-dirty
  • added edition = "2018" to Cargo.toml
  • ran cargo fix --edition-idioms --broken-code
  • fixed any errors/warning and removed whitespaces

@ascjones
core: cargo fix --edition
01f7c54
@ascjones
core: edition = 2018
a4fa04b
@ascjones
http: cargo fix --edition
e015f32
@ascjones
http: edition = 2018
02621c1
@ascjones
ipc: edition 2018
30819ac
@ascjones
pubsub: edition 2018
c7e49e2
@ascjones
pubsub: cargo fix --edition-idioms --broken-code, then fixed compile …
1f74eb6 
…errors
@ascjones
server-utils: cargo fix --edition
bb6e713
@ascjones
server-utils: edition 2018
601e5dc
@ascjones
server-utils: cargo fix --edition-idioms --broken-code
7cae780
@ascjones
stdio: edition 2018
d004ffb
@ascjones
stdio: edition 2018 idioms
2122c11
@ascjones
tcp: edition 2018
f0a531f
@ascjones
tcp: edition 2018 idioms
ea979bf
@ascjones
test: edition 2018
f7a859a
@ascjones
test: edition 2018 idioms
e73d851
@ascjones
ws: edition 2018
fb934bf
@ascjones
ws: edition 2018 idioms
9e013de
@ascjones
edition 2018: remove whitespaces from cargo fix
566f9c8
@ascjones
core: edition 2018 idioms
f5c972c
@ascjones
http: edition 2018 idioms
283052f
@ascjones
derive: edition 2018 idioms
39542fb
@ascjones
ipc: edition 2018 idioms
9add1fe
@ascjones
pubsub: edition 2018 idioms
e300a76
@ascjones
Remove more blank lines and unused
f4b945e
tomusdrw
tomusdrw suggested changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@tomusdrw tomusdrw left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Couple of grumbles, can you:

  1. get rid of dyn prefix
  2. get rid of elisionable (is that even a word?) lifetimes <'_>
  3. convert r#try! to ?
  4. Update readme examples (remoe extern crate)

core/src/calls.rs Outdated Show resolved Hide resolved
core/src/calls.rs Outdated Show resolved Hide resolved
http/src/lib.rs Outdated Show resolved Hide resolved
@tomusdrw tomusdrw merged commit 37b62a3 into master Jan 29, 2019
@tomusdrw tomusdrw deleted the aj-edition-2018 branch January 29, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to edition=2018
2 participants
@ascjones @tomusdrw