Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #[doc(hidden)] from implementation section #1272

Merged
merged 1 commit into from May 23, 2022

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented May 22, 2022

Fixes #1269

Removed #[doc(hidden)] from the implementation section because now it fully depends on the trait definition. __ink_TraitInfo is hidden in the trait - it is enough.

@paritytech-cicd-pr
Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the examples/* contracts from this branch with cargo-contract 1.3.0-cef152e and comparing them to ink! master:

Δ Optimized Size Δ Used Gas Total Optimized Size Total Used Gas
accumulator 1.04 K
adder 2.13 K
contract-introspection 2.37 K
contract-terminate 0.94 K 275_000
contract-transfer 8.13 K 75_000
data-structures 1.73 K
delegate-calls 2.96 K 76_276
delegator 6.38 K 232_281
dns 8.89 K 225_000
erc1155 17.30 K 450_000
erc20 8.49 K 225_000
erc721 11.82 K 600_000
flipper 1.31 K 75_000
forward-calls 2.88 K 151_427
incrementer 1.21 K
mother 12.36 K
multisig 25.29 K 470_275
rand-extension 3.92 K 75_000
seal-code-hash 1.58 K
seal-ecdsa 1.81 K
set-code-hash 1.57 K 150_000
subber 2.15 K
trait-erc20 8.77 K 225_000
trait-flipper 1.00 K 75_000
trait-incrementer 1.19 K 150_000
updated-incrementer 9.62 K
upgradeable-flipper 1.55 K

Link to the run | Last update: Sun May 22 21:30:14 CEST 2022

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2022

Codecov Report

Merging #1272 (5860be9) into master (64d5fd4) will increase coverage by 18.47%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1272       +/-   ##
===========================================
+ Coverage   47.93%   66.41%   +18.47%     
===========================================
  Files         176      176               
  Lines        5916     5916               
===========================================
+ Hits         2836     3929     +1093     
+ Misses       3080     1987     -1093     
Impacted Files Coverage Δ
...odegen/src/generator/as_dependency/contract_ref.rs 100.00% <ø> (+100.00%) ⬆️
...ng/codegen/src/generator/trait_def/call_builder.rs 100.00% <ø> (+100.00%) ⬆️
.../codegen/src/generator/trait_def/call_forwarder.rs 100.00% <ø> (+100.00%) ⬆️
.../codegen/src/generator/trait_def/trait_registry.rs 98.92% <ø> (+98.92%) ⬆️
crates/lang/ir/src/ir/selector.rs 80.00% <0.00%> (+8.00%) ⬆️
crates/lang/ir/src/ir/item_impl/callable.rs 87.87% <0.00%> (+10.10%) ⬆️
crates/lang/codegen/src/generator/ink_test.rs 75.00% <0.00%> (+75.00%) ⬆️
crates/lang/codegen/src/generator/dispatch.rs 94.31% <0.00%> (+94.31%) ⬆️
...ates/lang/codegen/src/generator/chain_extension.rs 95.74% <0.00%> (+95.74%) ⬆️
crates/lang/codegen/src/generator/events.rs 97.26% <0.00%> (+97.26%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d5fd4...5860be9. Read the comment docs.

@cmichi cmichi merged commit 1ebfc9a into use-ink:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to nightly rust v1.63.0 breaks breaks cargo test
4 participants