Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve upgradeable examples folder structure, explain differences #1188

Merged
merged 15 commits into from Mar 17, 2022

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Mar 17, 2022

Failure of the ink-waterfall CI stage is expected, since the paths have not yet been adapted there.

@cmichi cmichi requested a review from a team as a code owner March 17, 2022 07:48
@codecov-commenter
Copy link

Codecov Report

Merging #1188 (76d9d53) into master (a35e159) will decrease coverage by 17.22%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1188       +/-   ##
===========================================
- Coverage   78.98%   61.76%   -17.23%     
===========================================
  Files         229      228        -1     
  Lines        8667     8637       -30     
===========================================
- Hits         6846     5335     -1511     
- Misses       1821     3302     +1481     
Impacted Files Coverage Δ
crates/lang/codegen/src/traits.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/ir/src/ir/contract.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/env.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/mod.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/enforced_error.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/blake2b.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/storage.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/arg_list.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/contract.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/selector.rs 0.00% <0.00%> (-100.00%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a35e159...76d9d53. Read the comment docs.

@cmichi cmichi merged commit c474040 into master Mar 17, 2022
@cmichi cmichi deleted the cmichi-improve-upgradeable-examples-folder-structure branch March 17, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants