Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to parity-scale-codec 3 and scale-info 2 #1132

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

ascjones
Copy link
Collaborator

Supersedes #1124

@ascjones ascjones changed the title Update parity-scale-codec and scale-info requirements Update to parity-scale-codec 3 and scale-info 2 Feb 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #1132 (d9f1225) into master (67b457c) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1132      +/-   ##
==========================================
- Coverage   78.70%   78.66%   -0.05%     
==========================================
  Files         253      253              
  Lines        9411     9411              
==========================================
- Hits         7407     7403       -4     
- Misses       2004     2008       +4     
Impacted Files Coverage Δ
...ates/storage/src/collections/hashmap/fuzz_tests.rs 95.74% <0.00%> (-4.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b457c...d9f1225. Read the comment docs.

@paritytech-cicd-pr
Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the examples/* contracts from this branch with cargo-contract 0.17.0-942c50c and comparing them to ink! master:

Δ Optimized Size Δ Used Gas Total Optimized Size Total Used Gas
accumulator -0.08 K 1.35 K
adder -0.47 K 2.47 K
contract-terminate -0.08 K 1.23 K 215_704
contract-transfer -0.08 K 8.47 K 15_704
delegator -0.77 K -510 6.86 K 50_833
dns -0.51 K 9.70 K 47_112
erc1155 -0.20 K 28.12 K 94_224
erc20 -0.47 K 9.34 K 47_112
erc721 -0.53 K 13.17 K 125_632
flipper -0.13 K 1.63 K 15_704
incrementer -0.08 K 1.56 K 15_704
multisig -0.52 K -658 26.25 K 102_922
proxy -0.51 K -157 3.36 K 32_147
rand-extension -0.48 K 4.64 K 15_704
subber -0.47 K 2.48 K
trait-erc20 -0.47 K 9.64 K 47_112
trait-flipper -0.11 K 1.41 K 15_704
trait-incrementer -0.08 K 1.54 K 31_408

Link to the run | Last update: Tue Feb 15 12:01:01 CET 2022

@athei
Copy link
Contributor

athei commented Feb 15, 2022

Still strange that gas doesn't change for all contracts where the size changed. Is the size change maybe in a path that isn't hit by the waterfall?

Copy link
Contributor

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still strange that gas doesn't change for all contracts where the size changed. Is the size change maybe in a path that isn't hit by the waterfall?

I also find it strange, I can create a follow-up issue in the waterfall to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants