Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Suppress unused variable warning for debug_print macros (#1258)" #1276

Merged
merged 2 commits into from May 25, 2022

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented May 25, 2022

This reverts commit b6dd935.

See the discussion in #1258 (comment), there is a regression now. We need to revisit this. I'll create an issue once we've merged this PR.

@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented May 25, 2022

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the examples/* contracts from this branch with cargo-contract 1.4.0-45fbc0b and comparing them to ink! master:

Δ Optimized Size Δ Used Gas Total Optimized Size Total Used Gas
accumulator 1.00 K
adder 2.04 K
contract-introspection 2.32 K
contract-terminate 0.92 K 275_000
contract-transfer 8.13 K 75_000
data-structures 1.73 K
delegate-calls 2.89 K 76_242
delegator +1 6.34 K 232_136
dns 8.81 K 225_000
erc1155 16.74 K 450_000
erc20 8.42 K 225_000
erc721 11.62 K 600_000
flipper 1.24 K 75_000
forward-calls 2.87 K 151_411
incrementer 1.14 K
mother 12.15 K
multisig 25.28 K 470_240
rand-extension 3.79 K 75_000
seal-code-hash 1.39 K
seal-ecdsa 1.71 K
set-code-hash 1.49 K 150_000
subber 2.06 K
trait-erc20 8.69 K 225_000
trait-flipper 0.97 K 75_000
trait-incrementer 1.12 K 150_000
updated-incrementer 9.55 K
upgradeable-flipper 1.48 K

Link to the run | Last update: Wed May 25 09:56:08 CEST 2022

@codecov-commenter
Copy link

Codecov Report

Merging #1276 (fb22577) into master (260946f) will decrease coverage by 18.49%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1276       +/-   ##
===========================================
- Coverage   67.09%   48.59%   -18.50%     
===========================================
  Files         176      176               
  Lines        5920     5920               
===========================================
- Hits         3972     2877     -1095     
- Misses       1948     3043     +1095     
Impacted Files Coverage Δ
crates/lang/codegen/src/traits.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/env.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/mod.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/enforced_error.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/blake2b.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/storage.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/arg_list.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/contract.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/selector.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/trait_def/mod.rs 0.00% <0.00%> (-100.00%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260946f...fb22577. Read the comment docs.

@cmichi cmichi merged commit b25d6b8 into master May 25, 2022
@cmichi cmichi deleted the cmichi-revert-debug-println-fix branch May 25, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants