Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed collection and lazy from storage #1271

Merged

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented May 20, 2022

Moved to separate PR based on the comment.

@paritytech-cicd-pr
Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the examples/* contracts from this branch with cargo-contract 1.3.0-cef152e and comparing them to ink! master:

Δ Optimized Size Δ Used Gas Total Optimized Size Total Used Gas
accumulator 1.04 K
adder 2.13 K
contract-introspection 2.37 K
contract-terminate 0.94 K 275_000
contract-transfer 8.13 K 75_000
data-structures 1.73 K
delegate-calls 2.96 K 76_276
delegator 6.38 K 232_281
dns 8.89 K 225_000
erc1155 17.30 K 450_000
erc20 8.49 K 225_000
erc721 11.82 K 600_000
flipper 1.31 K 75_000
forward-calls 2.88 K 151_427
incrementer 1.21 K
mother -0.05 K 12.36 K
multisig +0.18 K +119 25.29 K 470_275
rand-extension 3.92 K 75_000
seal-code-hash 1.58 K
seal-ecdsa 1.81 K
set-code-hash 1.57 K 150_000
subber 2.15 K
trait-erc20 8.77 K 225_000
trait-flipper 1.00 K 75_000
trait-incrementer 1.19 K 150_000
updated-incrementer 9.62 K
upgradeable-flipper 1.55 K

Link to the run | Last update: Fri May 20 18:48:25 CEST 2022

@codecov-commenter
Copy link

Codecov Report

Merging #1271 (d9000e3) into master (3c267d6) will decrease coverage by 31.17%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1271       +/-   ##
===========================================
- Coverage   78.48%   47.31%   -31.18%     
===========================================
  Files         227      176       -51     
  Lines        8645     5916     -2729     
===========================================
- Hits         6785     2799     -3986     
- Misses       1860     3117     +1257     
Impacted Files Coverage Δ
crates/storage/src/lazy/mapping.rs 54.28% <ø> (ø)
crates/storage/src/test_utils.rs 95.77% <ø> (-3.14%) ⬇️
crates/storage/src/traits/mod.rs 100.00% <ø> (ø)
crates/storage/src/traits/optspec.rs 85.71% <ø> (-7.39%) ⬇️
crates/lang/codegen/src/traits.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/ir/src/ir/contract.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/env.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/mod.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/enforced_error.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/blake2b.rs 0.00% <0.00%> (-100.00%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c267d6...d9000e3. Read the comment docs.

@xgreenx xgreenx mentioned this pull request May 20, 2022
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HCastano HCastano merged commit 64d5fd4 into use-ink:master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants