Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make seal_ecdsa test cases differ from the ones used in the pallet #1268

Merged
merged 1 commit into from May 20, 2022

Conversation

agryaznov
Copy link
Contributor

@agryaznov agryaznov commented May 19, 2022

I suggest testing those ones versus different public keys in pallet_contracts, in doc comments examples in ink! and finally in e2e waterfall tests. By doing this we make the tests independent and more robust.

@paritytech-cicd-pr
Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the examples/* contracts from this branch with cargo-contract 1.3.0-cef152e and comparing them to ink! master:

Δ Optimized Size Δ Used Gas Total Optimized Size Total Used Gas
accumulator 1.04 K
adder 2.13 K
contract-introspection 2.37 K
contract-terminate 0.94 K 275_000
contract-transfer 8.13 K 75_000
data-structures 1.73 K
delegate-calls 2.96 K 76_276
delegator 6.38 K 232_281
dns 8.89 K 225_000
erc1155 17.30 K 450_000
erc20 8.49 K 225_000
erc721 11.82 K 600_000
flipper 1.31 K 75_000
forward-calls 2.88 K 151_427
incrementer 1.21 K
mother 12.41 K
multisig 25.12 K 470_156
rand-extension 3.92 K 75_000
seal-code-hash 1.58 K
seal-ecdsa 1.81 K
set-code-hash 1.57 K 150_000
subber 2.15 K
trait-erc20 8.77 K 225_000
trait-flipper 1.00 K 75_000
trait-incrementer 1.19 K 150_000
updated-incrementer 9.62 K
upgradeable-flipper 1.55 K

Link to the run | Last update: Fri May 20 16:56:30 CEST 2022

@codecov-commenter
Copy link

Codecov Report

Merging #1268 (d3fa1fb) into master (3c267d6) will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
+ Coverage   78.48%   78.72%   +0.23%     
==========================================
  Files         227      228       +1     
  Lines        8645     8675      +30     
==========================================
+ Hits         6785     6829      +44     
+ Misses       1860     1846      -14     
Impacted Files Coverage Δ
crates/env/src/api.rs 33.80% <ø> (ø)
crates/lang/src/env_access.rs 12.00% <ø> (ø)
...rates/storage/src/collections/binary_heap/tests.rs 93.33% <0.00%> (-2.23%) ⬇️
crates/lang/ir/src/ir/attrs.rs 81.99% <0.00%> (-0.28%) ⬇️
crates/allocator/src/bump.rs 0.00% <0.00%> (ø)
crates/engine/src/ext.rs 70.17% <0.00%> (+14.03%) ⬆️
crates/engine/src/test_api.rs 91.20% <0.00%> (+18.68%) ⬆️
crates/engine/src/chain_extension.rs 42.85% <0.00%> (+23.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c267d6...d3fa1fb. Read the comment docs.

@cmichi cmichi merged commit 6e0eefa into master May 20, 2022
@cmichi cmichi deleted the ag-ecdsa-tests branch May 20, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants