Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant TryFrom/Into & FromIterator imports #1206

Merged
merged 5 commits into from Apr 1, 2022

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Apr 1, 2022

Since edition 2021 they are in the prelude

@ascjones ascjones changed the title Remove redundant (since edition 2021) TryFrom imports Remove redundant TryFrom imports Apr 1, 2022
@ascjones ascjones changed the title Remove redundant TryFrom imports Remove redundant TryFrom imports Apr 1, 2022
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+4 −47

Nice!

@codecov-commenter
Copy link

Codecov Report

Merging #1206 (1474bc0) into master (3f7ea2b) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1206      +/-   ##
==========================================
- Coverage   79.03%   78.98%   -0.05%     
==========================================
  Files         229      229              
  Lines        8667     8667              
==========================================
- Hits         6850     6846       -4     
- Misses       1817     1821       +4     
Impacted Files Coverage Δ
crates/env/src/types.rs 22.22% <ø> (ø)
crates/lang/ir/src/ir/attrs.rs 82.27% <ø> (ø)
crates/lang/ir/src/ir/blake2.rs 80.00% <ø> (ø)
crates/lang/ir/src/ir/chain_extension.rs 93.46% <ø> (ø)
crates/lang/ir/src/ir/config.rs 96.49% <ø> (ø)
crates/lang/ir/src/ir/contract.rs 100.00% <ø> (ø)
crates/lang/ir/src/ir/ink_test.rs 87.50% <ø> (ø)
crates/lang/ir/src/ir/item/event.rs 89.55% <ø> (ø)
crates/lang/ir/src/ir/item/mod.rs 60.71% <ø> (ø)
crates/lang/ir/src/ir/item/storage.rs 80.64% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7ea2b...1474bc0. Read the comment docs.

@ascjones ascjones changed the title Remove redundant TryFrom imports Remove redundant TryFrom/Into & FromIterator imports Apr 1, 2022
@paritytech-cicd-pr
Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the examples/* contracts from this branch with cargo-contract 1.1.0-ef194a0 and comparing them to ink! master:

Δ Optimized Size Δ Used Gas Total Optimized Size Total Used Gas
accumulator 1.03 K
adder 2.17 K
contract-introspection 2.37 K
contract-terminate 0.94 K 214_418
contract-transfer 8.15 K 14_418
delegate-calls 2.99 K 14_950
delegator 6.37 K 46_295
dns 8.84 K 43_254
erc1155 17.23 K 86_508
erc20 8.49 K 43_254
erc721 11.81 K 115_344
flipper 1.31 K 14_418
forward-calls 2.90 K 29_536
incrementer 1.21 K 14_418
multisig 25.20 K 93_527
rand-extension 3.92 K 14_418
subber 2.19 K
trait-erc20 8.76 K 43_254
trait-flipper 1.00 K 14_418
trait-incrementer 1.19 K 28_836
upgradeable-flipper 1.55 K

Link to the run | Last update: Fri Apr 1 13:37:00 CEST 2022

@ascjones ascjones merged commit 6f105c2 into master Apr 1, 2022
@ascjones ascjones deleted the aj/remove-tryfrom-import branch April 1, 2022 12:11
@HCastano
Copy link
Contributor

HCastano commented Apr 3, 2022

Interesting, you'd think this is something Clippy could catch 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants