Skip to content

Prepare release 0.15 with SCALE 3.0.0 #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Conversation

wigy-opensource-developer
Copy link
Contributor

No description provided.

Unverified

No user is associated with the committer email.

Unverified

No user is associated with the committer email.
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to (or should?) bump scale-info to 2.0?

Cargo.toml Outdated
@@ -1,6 +1,6 @@
[package]
name = "finality-grandpa"
version = "0.14.4"
version = "0.14.5"
Copy link
Contributor

@andresilva andresilva Feb 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a major bump to "0.15.0" as people depending on Encode/Decode of these types will also need to bump their scale codec version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Also, I need to upgrade scale-info and primitive-types as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I think we can do all of that in this PR :)

@wigy-opensource-developer wigy-opensource-developer changed the title Prepare release 0.14.4 with SCALE 3.0.0 Prepare release 0.15 with SCALE 3.0.0 Feb 7, 2022

Unverified

No user is associated with the committer email.
@andresilva andresilva merged commit 14408e3 into master Feb 8, 2022
@andresilva andresilva deleted the wigy-upgrade-scale3 branch June 13, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants