Generate typescript for SVGs when using svgr and typescript option #8411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samjt
changed the title
mischnic
reviewed
Aug 23, 2022
mischnic
reviewed
Aug 23, 2022
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
|
@mischnic changes ready, thanks for the review |
mischnic
reviewed
Aug 23, 2022
|
The lint check is complaining that |
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
mischnic
reviewed
Aug 24, 2022
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
|
Sorry, a lot of back and forth on chores… |
|
@mischnic I think this is all ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Generate typescript using SVGR's
typescript:trueoption insvgrrc.jsonSVGR can generate typescript as well as plain javascript react components, but the option throws an error in Parcel because the input in the transformer is hard coded to
jsx.Fixes #8376
Related: #7741
🚨 Test instructions
Included integration tests svg-react-typescript use a
.svgrrc.jsonfile and apackage.jsonto transform to tsx and generate types based on the interface defined inreact.tsrun
yarn test:integration --grep 'SVG'to get the specific tests run✔️ PR Todo