Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dotenv package error #1953

Merged
merged 1 commit into from Aug 28, 2018
Merged

Fix dotenv package error #1953

merged 1 commit into from Aug 28, 2018

Conversation

subhero24
Copy link
Contributor

This fixes #1440. Package "dotenv" does something like "process.env.hasOwnProperty( ... )".
Parcel expects a value property lookup on process.env, not a function call. So valueToNode fails if it was called with a function like "hasOwnProperty".

NPM package "dotenv" does something like "process.env.hasOwnProperty( ... )".
Parcel expects a value property lookup on process.env, not a function call. So valueToNode fails if it was called with a function like "hasOwnProperty".
@DeMoorJasper DeMoorJasper merged commit 304c860 into parcel-bundler:master Aug 28, 2018
@subhero24 subhero24 deleted the fix-dotenv-error branch August 28, 2018 18:06
devongovett pushed a commit that referenced this pull request Oct 15, 2018
This fixes #1440. Package "dotenv" does something like "process.env.hasOwnProperty( ... )".
Parcel expects a value property lookup on process.env, not a function call. So valueToNode fails if it was called with a function like "hasOwnProperty".
devongovett pushed a commit that referenced this pull request Oct 15, 2018
This fixes #1440. Package "dotenv" does something like "process.env.hasOwnProperty( ... )".
Parcel expects a value property lookup on process.env, not a function call. So valueToNode fails if it was called with a function like "hasOwnProperty".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MemberExpressions attempts to convert process.env.hasOwnProperty to a node
2 participants