DRAFT: Initial @parcel/core rewrite in Rust #9704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alshdavid
force-pushed
the
experiment/core-rs
branch
4 times, most recently
from
b3f41be
to
fe77200
Compare
POC: call JS for entry requests Implement basic transformation algorithm load parcel config Port more of the js transformer Run transformer plugins serialize asset graph merge duplicate dependencies build bundle graph Target request run bundler plugin run bundler as a request Convert internal asset, dependency, and environment fields to numbers Implement drop-in replacement for AssetGraphRequest in JS implement more resolver features move environment better engines representation fix some tests diff graph
alshdavid
force-pushed
the
experiment/core-rs
branch
from
fe77200
to
d682ecd
Compare
alshdavid
commented
May 8, 2024
There was a problem hiding this comment.
TODO: support comments in JSON parser for config
yamadapc
requested changes
May 8, 2024
|
Will be breaking this PR down into smaller PRs to make it reviewable and help put it behind a feature flag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Will be breaking this PR down into smaller PRs to make it reviewable and help put it behind a feature flag
Credit to Devon for the majority of the PR content, I simply reformatted it adding:
Moving forward, the expectation is the Rust circuit will be enabled optionally behind a feature flag. It's expected that the rust-enabled builds will be broken initially. We will work off
v2and port more functionality over incrementally until it's in a working state.TODO
[] Putting this behind a feature flag
↪️ Pull Request
Introducing the Rust core rewrite behind a feature flag
Credit:
Devon, Matt, Monica