Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mjs and cjs to resolver extensions #8667

Merged
merged 1 commit into from Dec 6, 2022
Merged

Add mjs and cjs to resolver extensions #8667

merged 1 commit into from Dec 6, 2022

Conversation

devongovett
Copy link
Member

Not totally sure about the order we should use, but seems good to prioritize mjs.

Not totally sure about the order we should use, but seems good to prioritize mjs.
@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.77s +108.00ms ⚠️
Cached 365.00ms -49.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 94.00ms -167.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 95.00ms -167.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 95.00ms -166.00ms 🚀
dist/legacy/index.2c76ad23.js 1.66kb +0.00b 516.00ms +74.00ms ⚠️
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 517.00ms +75.00ms ⚠️
dist/modern/index.6be20f01.js 1.13kb +0.00b 516.00ms +75.00ms ⚠️
dist/legacy/index.html 826.00b +0.00b 655.00ms +92.00ms ⚠️
dist/modern/index.html 749.00b +0.00b 654.00ms +91.00ms ⚠️
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 304.00ms +37.00ms ⚠️
dist/modern/index.31cedca9.css 94.00b +0.00b 303.00ms +37.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 277.00ms +184.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 278.00ms +184.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 279.00ms +185.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 11.07s -96.00ms
Cached 474.00ms -29.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.96m +3.12s
Cached 2.68s +174.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/index.27632f4a.js 3.94mb +0.00b 52.05s +4.35s ⚠️
dist/pdfRenderer.717e6290.js 1.11mb +0.00b 1.32m +6.37s ⚠️
dist/editorView.f8e86b89.js 627.35kb +0.00b 1.59m +7.20s ⚠️
dist/refractor.a33d61f8.js 599.70kb +0.00b 1.59m +7.20s ⚠️
dist/media-viewer.3381b570.js 518.74kb +0.00b 1.32m +6.38s ⚠️
dist/popup.161ec9ff.js 322.41kb +0.00b 1.59m +7.20s ⚠️
dist/ConfigPanelFieldsLoader.71292279.js 312.70kb +0.00b 56.01s +4.67s ⚠️
dist/card.e5cee225.js 136.31kb +0.00b 1.32m +6.38s ⚠️
dist/EmojiPickerComponent.58efe218.js 95.42kb +0.00b 1.32m +6.37s ⚠️
dist/ConfigPanelFieldsLoader.c7f2aa0c.js 83.23kb +0.00b 1.32m +6.37s ⚠️
dist/mobile-upload.d7ac6521.js 68.12kb +0.00b 50.87s +4.08s ⚠️
dist/esm.ab7c7b7a.js 65.12kb +0.00b 1.59m +7.20s ⚠️
dist/ElementBrowser.05465fbe.js 62.44kb +0.00b 1.32m +6.37s ⚠️
dist/esm.e997ee63.js 61.48kb +0.00b 1.32m +6.38s ⚠️
dist/archive.b91410d8.js 61.47kb +0.00b 1.32m +6.37s ⚠️
dist/DatePicker.93c6d7f2.js 48.71kb +0.00b 56.01s +4.67s ⚠️
dist/component-lazy.1f0d85b0.js 48.50kb +0.00b 52.05s +4.35s ⚠️
dist/component.95bb1029.js 41.95kb +0.00b 50.89s +4.08s ⚠️
dist/esm.2613981d.js 40.66kb +0.00b 1.59m +7.20s ⚠️
dist/Modal.d50fae2a.js 28.71kb +0.00b 50.89s +4.08s ⚠️
dist/DatePicker.cb6a97f0.js 25.50kb +0.00b 56.01s +4.67s ⚠️
dist/smartMediaEditor.4380e25d.js 23.04kb +0.00b 1.59m +7.20s ⚠️
dist/esm.a4c15b2a.js 21.18kb +0.00b 1.59m +7.20s ⚠️
dist/component.19aeffe6.js 18.83kb +0.00b 50.87s +4.08s ⚠️
dist/js.59c58b0d.js 17.25kb +0.00b 50.86s +4.07s ⚠️
dist/ConfigPanelFieldsLoader.85392e43.js 16.22kb +0.00b 1.32m +6.37s ⚠️
dist/component.e1bd0f1e.js 15.48kb +0.00b 50.87s +4.08s ⚠️
dist/ui.fd196b0f.js 14.67kb +0.00b 1.32m +6.37s ⚠️
dist/dropzone.022632dd.js 13.91kb +0.00b 1.59m +7.20s ⚠️
dist/ConfigPanelFieldsLoader.35dd5c20.js 13.87kb +0.00b 1.32m +6.37s ⚠️
dist/dropzone.ad2bddc5.js 12.82kb +0.00b 1.59m +7.20s ⚠️
dist/component-lazy.6c68ff48.js 9.96kb +0.00b 52.05s +4.35s ⚠️
dist/Toolbar.f13c635f.js 9.69kb +0.00b 1.59m +7.20s ⚠️
dist/pdfRenderer.807762df.js 9.60kb +0.00b 1.32m +6.37s ⚠️
dist/clipboard.30b6a808.js 9.04kb +0.00b 1.59m +7.20s ⚠️
dist/browser.ff965d34.js 8.30kb +0.00b 1.59m +7.20s ⚠️
dist/mobile-upload.3b49b63c.js 8.11kb +0.00b 50.86s +4.07s ⚠️
dist/mobile-upload.327a0503.js 8.11kb +0.00b 1.32m +6.38s ⚠️
dist/mobile-upload.c045db2b.js 8.11kb +0.00b 1.32m +6.38s ⚠️
dist/mobile-upload.3aa19528.js 8.11kb +0.00b 1.59m +7.20s ⚠️
dist/index.b16227d6.css 4.08kb +0.00b 1.59m +7.26s ⚠️
dist/Modal.85101605.js 4.07kb +0.00b 50.87s +4.08s ⚠️
dist/png-chunks-extract.f2395929.js 3.47kb +0.00b 50.86s +4.07s ⚠️
dist/media-viewer-analytics-error-boundary.6847f80f.js 3.43kb +0.00b 1.59m +7.20s ⚠️
dist/media-picker-analytics-error-boundary.6cc3986f.js 3.43kb +0.00b 1.59m +7.20s ⚠️
dist/media-card-analytics-error-boundary.fbc27a0b.js 3.43kb +0.00b 1.59m +7.20s ⚠️
dist/component.0685539f.js 3.40kb +0.00b 50.87s +4.07s ⚠️
dist/ru.fdb600e7.js 2.94kb +0.00b 1.32m +6.37s ⚠️
dist/uk.aeae0dd4.js 2.91kb +0.00b 1.32m +6.37s ⚠️
dist/codeViewerRenderer.83de4f0d.js 2.79kb +0.00b 1.32m +6.37s ⚠️
dist/th.bcd8fad5.js 2.75kb +0.00b 1.32m +6.37s ⚠️
dist/ResourcedEmojiComponent.bef36b85.js 2.68kb +0.00b 56.01s +4.67s ⚠️
dist/pl.4643976c.js 2.37kb +0.00b 56.01s +4.67s ⚠️
dist/cs.08737142.js 2.28kb +0.00b 56.01s +4.67s ⚠️
dist/de.c2e79abd.js 2.26kb +0.00b 56.01s +4.67s ⚠️
dist/es.983af340.js 2.24kb +0.00b 56.01s +4.67s ⚠️
dist/ja.b56014f3.js 2.24kb +0.00b 56.01s +4.67s ⚠️
dist/fr.aaa4d0bf.js 2.20kb +0.00b 56.01s +4.67s ⚠️
dist/pt_BR.6c08dcf7.js 2.17kb +0.00b 56.01s +4.67s ⚠️
dist/hu.3d2e30a0.js 2.17kb +0.00b 56.01s +4.67s ⚠️
dist/tr.3968c433.js 2.15kb +0.00b 1.32m +6.37s ⚠️
dist/vi.bf757a1c.js 2.15kb +0.00b 1.32m +6.37s ⚠️
dist/fi.080f52aa.js 2.13kb +0.00b 56.01s +4.67s ⚠️
dist/ko.51863560.js 2.13kb +0.00b 56.01s +4.67s ⚠️
dist/it.7bb93510.js 2.12kb +0.00b 56.01s +4.67s ⚠️
dist/nb.67163f41.js 2.10kb +0.00b 56.01s +4.67s ⚠️
dist/date.728667d8.js 2.10kb +0.00b 52.06s +4.35s ⚠️
dist/sv.51378563.js 2.09kb +0.00b 1.32m +6.37s ⚠️
dist/nl.336a2549.js 2.09kb +0.00b 56.01s +4.67s ⚠️
dist/da.f39b0c8c.js 2.07kb +0.00b 56.01s +4.67s ⚠️
dist/images.0fe0f35c.js 2.05kb +0.00b 52.06s +4.35s ⚠️
dist/zh_TW.6ca95d33.js 2.00kb +0.00b 1.32m +6.37s ⚠️
dist/zh.9b716de5.js 1.99kb +0.00b 1.32m +6.37s ⚠️
dist/feedback.2ade51a8.js 1.92kb +0.00b 56.01s +4.67s ⚠️
dist/status.2160efcd.js 1.82kb +0.00b 52.06s +4.35s ⚠️
dist/workerHasher.1e502a56.js 1.72kb +0.00b 50.86s +4.07s ⚠️
dist/workerHasher.0904bc5b.js 1.72kb +0.00b 1.32m +6.37s ⚠️
dist/workerHasher.6ae6406c.js 1.72kb +0.00b 1.32m +6.38s ⚠️
dist/workerHasher.23d0f86c.js 1.72kb +0.00b 1.59m +7.20s ⚠️
dist/workerHasher.6290622a.js 1.72kb +0.00b 1.59m +7.20s ⚠️
dist/workerHasher.e50d242f.js 1.72kb +0.00b 1.59m +7.20s ⚠️
dist/code.414e2c00.js 1.72kb +0.00b 52.06s +4.35s ⚠️
dist/list-number.2be0cd6c.js 1.62kb +0.00b 52.06s +4.35s ⚠️
dist/heading6.e0c2f3cf.js 1.52kb +0.00b 56.01s +4.67s ⚠️
dist/heading3.5b4663e8.js 1.51kb +0.00b 56.01s +4.67s ⚠️
dist/16.2ca688c7.js 1.48kb +0.00b 50.88s +4.09s ⚠️
dist/link.1e33efbb.js 1.43kb +0.00b 52.06s +4.35s ⚠️
dist/16.497f5b12.js 1.41kb +0.00b 50.88s +4.09s ⚠️
dist/emoji.5404dc09.js 1.40kb +0.00b 52.06s +4.35s ⚠️
dist/heading5.df611011.js 1.39kb +0.00b 56.01s +4.67s ⚠️
dist/expand.655beb16.js 1.33kb +0.00b 56.01s +4.67s ⚠️
dist/heading2.54f14b16.js 1.33kb +0.00b 52.06s +4.35s ⚠️
dist/heading4.3ae44c0a.js 1.28kb +0.00b 56.01s +4.67s ⚠️
dist/mention.85e501f2.js 1.24kb +0.00b 52.06s +4.35s ⚠️
dist/layout.dde5aa7a.js 1.20kb +0.00b 52.06s +4.35s ⚠️
dist/divider.3af42f3a.js 1.20kb +0.00b 52.06s +4.35s ⚠️
dist/action.633b1d3a.js 1.17kb +0.00b 52.06s +4.35s ⚠️
dist/heading1.216107b4.js 1.17kb +0.00b 52.06s +4.35s ⚠️
dist/list.1bd3e768.js 1.14kb +0.00b 52.06s +4.35s ⚠️
dist/quote.707178c1.js 1.14kb +0.00b 52.06s +4.35s ⚠️
dist/16.9b57f665.js 1.13kb +0.00b 50.88s +4.09s ⚠️
dist/decision.5c187f01.js 1.12kb +0.00b 52.06s +4.35s ⚠️
dist/panel-warning.817f153e.js 1.10kb +0.00b 52.06s +4.35s ⚠️
dist/16.58ff0dfa.js 1.08kb +0.00b 50.88s +4.09s ⚠️
dist/16.d4285343.js 1.08kb +0.00b 50.88s +4.09s ⚠️
dist/table.71e953fa.js 1.08kb +0.00b 52.06s +4.35s ⚠️
dist/16.1811e668.js 1.06kb +0.00b 50.87s +4.08s ⚠️
dist/16.095da4b1.js 1.06kb +0.00b 52.05s +4.35s ⚠️
dist/16.37c7d353.js 1.02kb +0.00b 52.05s +4.35s ⚠️
dist/panel.63b53aef.js 1.02kb +0.00b 52.06s +4.35s ⚠️
dist/panel-error.3c204bc9.js 1019.00b +0.00b 52.06s +4.35s ⚠️
dist/16.304b2149.js 991.00b +0.00b 50.88s +4.09s ⚠️
dist/16.88032cb6.js 963.00b +0.00b 50.88s +4.09s ⚠️
dist/panel-success.bfed2890.js 960.00b +0.00b 52.06s +4.35s ⚠️
dist/16.985ed0b8.js 956.00b +0.00b 50.87s +4.08s ⚠️
dist/16.d45c9dcb.js 950.00b +0.00b 52.05s +4.35s ⚠️
dist/panel-note.badaa0b2.js 950.00b +0.00b 52.06s +4.35s ⚠️
dist/16.7f99b86f.js 911.00b +0.00b 50.88s +4.09s ⚠️
dist/16.ff51ae00.js 905.00b +0.00b 50.88s +4.09s ⚠️
dist/16.0885132f.js 905.00b +0.00b 50.88s +4.09s ⚠️
dist/16.86eb7780.js 904.00b +0.00b 50.88s +4.09s ⚠️
dist/16.ff95e700.js 903.00b +0.00b 50.88s +4.09s ⚠️
dist/16.42ab2aa6.js 902.00b +0.00b 50.87s +4.08s ⚠️
dist/16.38996b14.js 875.00b +0.00b 52.05s +4.35s ⚠️
dist/16.bf3deacf.js 854.00b +0.00b 50.87s +4.08s ⚠️
dist/16.5e047b28.js 826.00b +0.00b 50.88s +4.08s ⚠️
dist/sk.dd4e83c8.js 791.00b +0.00b 1.32m +6.37s ⚠️
dist/pt_PT.1eda577d.js 786.00b +0.00b 56.01s +4.67s ⚠️
dist/et.03b90e09.js 778.00b +0.00b 56.01s +4.67s ⚠️
dist/simpleHasher.82f6b150.js 742.00b +0.00b 50.86s +4.07s ⚠️
dist/simpleHasher.2e0de700.js 742.00b +0.00b 1.32m +6.37s ⚠️
dist/simpleHasher.28ade3b5.js 742.00b +0.00b 1.32m +6.38s ⚠️
dist/simpleHasher.cc19c690.js 742.00b +0.00b 1.59m +7.20s ⚠️
dist/simpleHasher.76c4e98e.js 742.00b +0.00b 1.59m +7.20s ⚠️
dist/simpleHasher.46d6f2e5.js 742.00b +0.00b 1.59m +7.20s ⚠️
dist/is.0d0b2897.js 638.00b +0.00b 56.01s +4.67s ⚠️
dist/ro.82d888a1.js 633.00b +0.00b 1.32m +6.37s ⚠️
dist/en_GB.a4eaa606.js 623.00b +0.00b 56.01s +4.67s ⚠️
dist/en.dced70ab.js 620.00b +0.00b 56.01s +4.67s ⚠️
dist/index.html 167.00b +0.00b 1.59m +7.40s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 8.37s -97.00ms
Cached 304.00ms -9.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 334e8a5 into v2 Dec 6, 2022
@devongovett devongovett deleted the mjs-cjs branch December 6, 2022 19:22
lettertwo added a commit that referenced this pull request Dec 8, 2022
* upstream/v2:
  Make sure we're compiling on ubuntu-20.04
  v2.8.1
  Add mjs and cjs to resolver extensions (#8667)
  Fix transformer-svg-react not finding .svgrrc's (#7741)
  Fix overriding single export of a `export *` (#8653)
  chore: spelling fix (#8614)
  Parse shortcut icons in web app manifests (#8660)
  Make ts-types transformer work with TS >= 4.8 (#8661)
  Don't retarget dependencies with `*` (#8645)
  fix: remove @parcel/utils dep in @parcel/graph (#8630)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants