Add parcel-query function to locate a symbol by local name #8452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lettertwo
changed the title
mischnic
reviewed
Sep 7, 2022
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
mischnic
reviewed
Sep 12, 2022
|
|
||
| // If the asset couldn't be found by searching for the id, | ||
| // search for the local name in asset used symbols. | ||
| if (asset == null) { |
There was a problem hiding this comment.
Did you actually run into such a case? I can't think of a situation where the first search would fail
There was a problem hiding this comment.
I think you're right that this shouldn't be possible, but if there is an undefined symbol at runtime (due to a bug in Parcel), it likely won't be discoverable via the asset graph, but might still be discoverable in used symbols. (I have one such case that I am investigating and can share).
There was a problem hiding this comment.
Here's the case i mentioned: #8468
First pass optimistically looks for a matching id. Second pass will examine asset symbols, which could be much slower if there are a lot of assets and symbols.
lettertwo
force-pushed
the
parcel-query-find-asset-with-symbol
branch
from
2408949
to
518a398
Compare
AGawrys
approved these changes
Dec 13, 2022
mischnic
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the output for
findAsset.Some examples of how it works:
An imported symbol:
A declared symbol: