HMR Webworker: window isn't available

[mischnic]

Hello, I'm currently getting an HMR error in my WebWorkers that seems to be related to a use of the window global in the hmr runtime here. It wasn't clear to me if the fix was as simple as changing window.location.reload() to location.reload() and if there had been an unintentional regression introduced by #2676 so for now I'm just leaving this note -- any comments welcome. thanks, nehal

Originally posted by @habemus-papadum in #528 (comment)

[mischnic]

self.location.reload isn't actually defined for a worker.
The only solution I see is disabling (traditional) HMR for workers.

[habemus-papadum]

#529 seems to try to fix a similar problem (at a different location in the hmr runtime) by changing window.location.reload to location.reload. Also see the comments in #476 regarding self.location vs accessing location via implicit global. Was this fix incorrect or am I misunderstanding?

[mischnic]

There are two issues here:

• First, window isn't the global object inside a worker
• If you remove window, location.reload would be undefined (and that call would fail), because it doesn't exist in a worker (what does reloading a JS file mean, anyway): https://developer.mozilla.org/en-US/docs/Web/API/WorkerLocation#Methods

[mischnic]

Closing for #3076