Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing CI #2588

Closed
DanielRuf opened this issue Jan 28, 2019 · 4 comments · Fixed by #2591
Closed

Failing CI #2588

DanielRuf opened this issue Jan 28, 2019 · 4 comments · Fixed by #2591

Comments

@DanielRuf
Copy link

It seems CI status is red since a while. =(

https://dev.azure.com/devongovett/devongovett/_build/results?buildId=811

@DeMoorJasper
Copy link
Member

Someone was working on getting it fixed, but it appears the PR has been pretty inactive #2532

@mischnic
Copy link
Member

but it appears the PR has been pretty inactive

Hey 😄
I have no idea why htmlnano produces no extra linebreaks on windows and whether that's actually the correct behavior (don't think so).

@DeMoorJasper
Copy link
Member

DeMoorJasper commented Jan 28, 2019

@mischnic what about refactoring the tests so it compares the input file size with the minified output file size?
Completely getting rid of the testing linebreaks, as long as it minifies it should be good enough for Parcel afaik.
Testing linebreaks and such goes a bit too far imo as that's what htmlnano should test for already.
In the past it however was the quickest way to verify minification as it used to remove the linebreaks...

I'd be happy to experiment a lil with the tests if you don't have time to try some things atm

@mischnic
Copy link
Member

I'd be happy to experiment a lil with the tests if you don't have time to try some things atm

Go ahead! I'd have to setup my Windows machine again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants