Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to add comments to PRs originating from outside parcel-bundler/parcel #11

Open
DeMoorJasper opened this issue Oct 5, 2019 · 2 comments

Comments

@DeMoorJasper
Copy link
Member

DeMoorJasper commented Oct 5, 2019

Apparently Github Actions run from the source branch not the target branch, so the apikey is undefined if a PR compares with a branch outside of the Parcel org.

Not having an API key is not an option unless we run the benchmarks on a seperate server. Related which might happen, see: #8 but than we'd also need to verify the source to ensure no-one can submit incorrect benchmarks

@devongovett
Copy link
Member

maybe whitelist an ip range for github actions?

@DeMoorJasper
Copy link
Member Author

Can't really seem to find an ip range for github actions, I guess I could log all ips that go into the api server and try and figure out the ip-range by hand...

It would also allow anyone to write a github action and push to the parcel benchmark api which probably isn't ideal. (although a chance of anyone going through all that trouble just to post a false benchmark seems unlikely)

I think the only way to do this without anyone being able to report a false report would be to run the entire action on a server we control whether it being some cloud vm we boot up for every action or a dedicated machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants