Disable syn default features in lightningcss-derive #361
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disables the default syn features in lightningcss-derive's Cargo.toml. It also removes an unused syn feature. Related: parcel-bundler#357
chinedufn
commented
Dec 13, 2022
| @@ -11,6 +11,6 @@ repository = "https://github.com/parcel-bundler/lightningcss" | |||
| proc-macro = true | |||
|
|
|||
| [dependencies] | |||
| syn = { version = "1.0", features = ["extra-traits"] } | |||
| syn = { version = "1.0", default-features = false } | |||
There was a problem hiding this comment.
I didn't check how much was saved here.
In the past I've seen a similar change save about 1s of compile time ia0/data-encoding#56 (comment)
chinedufn
changed the title
devongovett
approved these changes
Dec 14, 2022
devongovett
added a commit
that referenced
this pull request
Jan 4, 2023
This reverts commit fc3e08a.
devongovett
added a commit
that referenced
this pull request
Jan 4, 2023
|
Unfortunately this seems to have broken |
|
Ah yeah I should've tried to build the crate on its own. Sounds good to me, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the default syn features in lightningcss-derive's
Cargo.toml.
It also removes an unused syn feature.
Related: #357