Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all architecture specific test binaries #2130

Open
kakkoyun opened this issue Oct 10, 2023 · 1 comment
Open

Remove all architecture specific test binaries #2130

kakkoyun opened this issue Oct 10, 2023 · 1 comment
Labels
testing Something about testing

Comments

@kakkoyun
Copy link
Member

kakkoyun commented Oct 10, 2023 •
edited

We have various binaries for testing in testdata directories for the corresponding package.
Instead of this approach, we should add them to https://github.com/parca-dev/testdata for each architecture we support.

ref: #2420
xref: added by parca-dev/testdata#27
@kakkoyun kakkoyun added the testing Something about testing label Oct 10, 2023
@kakkoyun
Copy link
Member Author

kakkoyun commented Feb 13, 2024 •
edited

This should be closed when #2420 is closed.

We have some binaries checked in the agent repo itself. We need to either move them to testdata repo or add arm64 for equivalents in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Something about testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kakkoyun