Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/e2e: Ensure tests are blocking #2036

Open
javierhonduco opened this issue Sep 20, 2023 · 0 comments
Open

tests/e2e: Ensure tests are blocking #2036

javierhonduco opened this issue Sep 20, 2023 · 0 comments
Labels
testing Something about testing

Comments

@javierhonduco
Copy link
Contributor

In 28f5ed1 the real gRPC client got accidentally removed. The e2e tests should catch this, and they indeed did! https://github.com/parca-dev/parca-agent/actions/runs/6235691586/job/16926054803 but unfortunately they didn't block the PR from merging. We should change this

cc @kakkoyun @Sylfrena
@javierhonduco javierhonduco added the testing Something about testing label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Something about testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@javierhonduco