Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - get_hostnames fails if "Match all" in config is followed by an include #2339

Open
dirtyhillbilly opened this issue Dec 26, 2023 · 0 comments · May be fixed by #2340
Open

[BUG] - get_hostnames fails if "Match all" in config is followed by an include #2339

dirtyhillbilly opened this issue Dec 26, 2023 · 0 comments · May be fixed by #2340
Labels

Comments

@dirtyhillbilly
Copy link

Are you using paramiko as a client or server?

Client

What feature(s) aren't working right?

sshconfig

What version(s) of paramiko are you using?

3.4.0

What version(s) of Python are you using?

3.11.2

What operating system and version are you using?

debian/linux

If you're connecting as a client, which SSH server are you connecting to?

No response

If you're using paramiko as part of another tool, which tool/version?

No response

Expected/desired behavior

I have a ~/.ssh/config that ends with:

Match all
Include ~/.ssh/config.local

Even if Include is not supported yet in paramiko, we should be able to get hostnames from main file.

Actual behavior

config.get_hostnames() crashes when using this config.

How to reproduce

No response

Anything else?

No response

dirtyhillbilly pushed a commit to dirtyhillbilly/paramiko that referenced this issue Dec 26, 2023
dirtyhillbilly pushed a commit to dirtyhillbilly/paramiko that referenced this issue Dec 26, 2023
get_hostname() crashedsif "Match" is not followed by a
"Host" section in .ssh/config.

Closes paramiko#2339
dirtyhillbilly pushed a commit to dirtyhillbilly/paramiko that referenced this issue Dec 26, 2023
get_hostname() crashes if "Match" is not followed by a
"Host" section in .ssh/config.

Closes paramiko#2339
dirtyhillbilly pushed a commit to dirtyhillbilly/paramiko that referenced this issue Dec 28, 2023
get_hostname() crashes if "Match" is not followed by a
"Host" section in .ssh/config.

Closes paramiko#2339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant