util: store thread assigned id in thread-local storage #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks like this only actually impacts that log_to_file function, which I suppose some users are referencing, but of course the practical effect is that it bloats memory for ALL users. Works for me under Python 2 and 3 (wasn't sure when threadlocals grew an 'id' attribute - not seeing it in a trivial test, but it's clearly working in the real...). |
bitprophet
added a commit
that referenced
this pull request
Mar 18, 2022
bitprophet
added a commit
that referenced
this pull request
Mar 18, 2022
|
Cherry-picked into 2.10 tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2002