Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable 0.8.1 release depends on tss-esapi alpha #527

Closed
nullr0ute opened this issue Sep 19, 2021 · 4 comments
Closed

Stable 0.8.1 release depends on tss-esapi alpha #527

nullr0ute opened this issue Sep 19, 2021 · 4 comments

Comments

@nullr0ute
Copy link

Is there an active reason to require a alpha of tss-esapi for the 0.8.1 stable release of parsec?

Problem: nothing provides requested (crate(tss-esapi/default) >= 7.0.0~alpha.1 with crate(tss-esapi/default) < 8.0.0~)
@hug-dev
Copy link
Member

hug-dev commented Sep 20, 2021

Asked in the linked issue above. Does that mean that you can't fetch any alpha version in your build system?

@nullr0ute
Copy link
Author

I wouldn't expect a minor stable dot release of something to move to a major alpha release of a dependency, that generally indicates new features rather than bug fix, which probably should be happening on the main branch for the 0.9.x feature release of parsec.

@nullr0ute
Copy link
Author

nullr0ute commented Sep 21, 2021

Is there a bug fix or something critical in tss-esapi that warrants the jump in requirements there?

@MattDavis00
Copy link
Member

MattDavis00 commented Sep 21, 2021

There is a bug fix for #504 (TPM Provider does not persist generated keys across reboot). The fix required changes in the rust-tss-esapi crate and Parsec. I believe the rust-tss-esapi PR made breaking changes as part of the fix, hence the major version change. The new Parsec version uses this new version of rust-tss-esapi to consume some of the fixes for the TPM issue, no new features have been added to Parsec. Hopefully this answers some of your questions, if not @ionut-arm (contributor for the PRs) or @hug-dev are likely your best points of contact.

Relevant PRs:
Parsec: #515
rust-tss-esapi: parallaxsecond/rust-tss-esapi#256

@hug-dev hug-dev closed this as completed Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants