Help for this issue to understand some things that i need to do

[DoTheBestToGetTheBest]

Hello everyone and thank you for reading this discussion asking for help.

I'am really loving working in reth, i hope getting better in future in reth.

So i'm taking this issue : #4874

And what i undertand i need to add Terminate and Terminated in the enum Discv4Command

What does terminate and terminated should do exactly ? does terminate should stop the discv4 service ? and terminated should verify if it's stopped ?

And also what does Terminate and Terminated should take in argument ?

Thank you all for your help !

[mattsse]

the terminate command variant needs to be sent like this:

reth/crates/net/discv4/src/lib.rs

Lines 366 to 375 in 858ea41

	#[inline]
	fn send_to_service(&self, cmd: Discv4Command) {
	let _ = self.to_service.send(cmd).map_err(|err| {
	debug!(
	target : "discv4",
	%err,
	"channel capacity reached, dropping command",
	)
	});
	}

see also this for reference

reth/crates/net/discv4/src/lib.rs

Lines 323 to 329 in 858ea41

	/// Adds the ip to the ban list.
	///
	/// This will prevent any future inclusion in the table
	pub fn ban_ip(&self, ip: IpAddr) {
	let cmd = Discv4Command::BanIp(ip);
	self.send_to_service(cmd);
	}

then it needs to be handled like this:

reth/crates/net/discv4/src/lib.rs

Lines 1532 to 1534 in 858ea41

	Discv4Command::BanIp(ip) => {
	self.ban_ip(ip);
	}

• emit a Terminated event and return Poll::Ready to terminate the future

[DoTheBestToGetTheBest]

Amazing, thank you so much !

[DoTheBestToGetTheBest]

Currently what i've done :

creating a Terminated elements in the Discv4Command enums

creating a service_send for Discv4Command::Terminated elements

pub fn terminate(&self) {
        let cmd = Discv4Command::Terminated;
        self.send_to_service(cmd);
    }

in the Discv4 struct

i created also a match for Discv4command::Terminated => todo!

What should exactly i do now please?

[mattsse]

please open a draft

[DoTheBestToGetTheBest]

Alright, thank you for your answer Mat!