Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #384

Merged
merged 3 commits into from Aug 10, 2021
Merged

Update README.md #384

merged 3 commits into from Aug 10, 2021

Conversation

rikemonni
Copy link
Contributor

Passport strategy's sessionKey's documentation was missing.

Thanks for this useful module 馃憤

@rikemonni
Update README.md
7506c1c 
Passport strategy's sessionKey's documentation was missing.
panva
panva requested changes Aug 10, 2021
View reviewed changes
Copy link
Owner

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on it being missing, let's reword it to reflect its actual use and in consistent documentation style.

docs/README.md Outdated Show resolved Hide resolved
panva
panva reviewed Aug 10, 2021
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
@panva panva merged commit e1531c3 into panva:main Aug 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@panva panva panva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rikemonni @panva