Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker command runner env tests are flaky #16749

Open
tdyas opened this issue Sep 1, 2022 · 3 comments
Open

docker command runner env tests are flaky #16749

tdyas opened this issue Sep 1, 2022 · 3 comments
Labels
backend: Docker Docker backend-related issues flaky-test

Comments

@tdyas
Copy link
Contributor

tdyas commented Sep 1, 2022

https://github.com/pantsbuild/pants/runs/8142213577?check_suite_focus=true#step:17:1192

The env and env_is_deterministic tests are flaky. Find out why. Could be a race condition in how container outputs are obtained.
@tdyas tdyas mentioned this issue Sep 1, 2022
Merged
@tdyas
Copy link
Contributor Author

tdyas commented Sep 1, 2022

env_is_deterministic flaky test run: https://github.com/pantsbuild/pants/runs/8121604214?check_suite_focus=true#step:17:1194

@tdyas tdyas self-assigned this Sep 1, 2022
tdyas pushed a commit that referenced this issue Sep 1, 2022
mark another flaky docker test (#16750)
29bc93e 
Mark `process_execution::docker_tests::env` as ignored since it is flaky as per #16749.

[ci skip-build-wheels]
@tdyas tdyas mentioned this issue Sep 3, 2022
Closed
@tdyas
Copy link
Contributor Author

tdyas commented Sep 3, 2022

I attempted to fix this issue in WIP PR #16766, but Docker fails to close the output stream and I don't see a way yet to peek and see if output has been fully consumed. Needs more work next week.

@tdyas
Copy link
Contributor Author

tdyas commented Sep 3, 2022

Asked a question upstream for bollard crate: fussybeaver/bollard#251

@thejcannon thejcannon added the backend: Docker Docker backend-related issues label Sep 30, 2022
@tdyas tdyas removed their assignment Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend: Docker Docker backend-related issues flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docker: attempt to fix intermittently uncaptured output tdyas/pants
2 participants
@tdyas @thejcannon