Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Score computation improvement #23

Open
minottic opened this issue Jul 8, 2022 · 1 comment
Open

Score computation improvement #23

minottic opened this issue Jul 8, 2022 · 1 comment

Comments

@minottic
Copy link

minottic commented Jul 8, 2022

I think score computation can be simplified.

From what I understand, you take the TFIDF(I,t) matrix and do the product with a matrix of 1 column of 1s.

If this is correct, the cosine similarity of one item should be the same as summing all the non-zero elements of this document in the TFIDF and dividing them by (the sum of their square * number of terms)

@nitrosx
Copy link
Collaborator

nitrosx commented Jul 8, 2022

@minottic I have to admit that I do not remember the details of the cosine similarity method (although I studied them when I coded the scoring system).
If your suggestion holds, I will be happy to implement your solution.
Do you have any suggestion on how we can test it?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants