From 8e73ce5fe1d2237b41e021b74cf9a272a6b3ce72 Mon Sep 17 00:00:00 2001 From: Kenichi Kamiya Date: Tue, 20 Jun 2023 19:10:49 +0900 Subject: [PATCH 1/4] Use the same version of nodejs as specified in .tool-versions https://github.com/actions/setup-node/pull/373 Since setup-node@v3 https://github.com/actions/setup-node/commit/5b949b50c3461bbcd5a540b150c368278160234a --- .github/workflows/hashira-web--test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/hashira-web--test.yml b/.github/workflows/hashira-web--test.yml index b83ddf3f..09230026 100644 --- a/.github/workflows/hashira-web--test.yml +++ b/.github/workflows/hashira-web--test.yml @@ -25,9 +25,9 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v3 with: - node-version: "14" + node-version-file: "hashira-web/.tool-versions" cache: "yarn" cache-dependency-path: "hashira-web/yarn.lock" - run: yarn install From dcf99d404bf32f7fdda2a6faf65f46f701ddd96f Mon Sep 17 00:00:00 2001 From: Kenichi Kamiya Date: Tue, 20 Jun 2023 19:27:05 +0900 Subject: [PATCH 2/4] Bump nodejs version as firebase-tools compat --- hashira-web/.tool-versions | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hashira-web/.tool-versions b/hashira-web/.tool-versions index 1f70ea7b..3c32310e 100644 --- a/hashira-web/.tool-versions +++ b/hashira-web/.tool-versions @@ -1,2 +1,2 @@ yarn 1.22.15 -nodejs 16.11.0 +nodejs 16.20.0 From 7e6b1afd1d618f2d690d0fd670b980009e05dd2e Mon Sep 17 00:00:00 2001 From: Kenichi Kamiya Date: Tue, 20 Jun 2023 19:39:31 +0900 Subject: [PATCH 3/4] `yarn add "@types/node@^16.18.36" --save-dev` --- hashira-web/package.json | 1 + hashira-web/yarn.lock | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/hashira-web/package.json b/hashira-web/package.json index a8a8f84c..1634728c 100644 --- a/hashira-web/package.json +++ b/hashira-web/package.json @@ -33,6 +33,7 @@ "vite": "^4.2.0" }, "dependencies": { + "@types/node": "^16.18.36", "firebase": "^9.22.1", "react": "^18.2.0", "react-dom": "^18.2.0", diff --git a/hashira-web/yarn.lock b/hashira-web/yarn.lock index 24728be2..1ace93a0 100644 --- a/hashira-web/yarn.lock +++ b/hashira-web/yarn.lock @@ -1174,6 +1174,11 @@ resolved "https://registry.yarnpkg.com/@types/node/-/node-18.0.0.tgz#67c7b724e1bcdd7a8821ce0d5ee184d3b4dd525a" integrity sha512-cHlGmko4gWLVI27cGJntjs/Sj8th9aYwplmZFwmmgYQQvL5NUsgVJG7OddLvNfLqYS31KFN0s3qlaD9qCaxACA== +"@types/node@^16.18.36": + version "16.18.36" + resolved "https://registry.yarnpkg.com/@types/node/-/node-16.18.36.tgz#0db5d7efc4760d36d0d1d22c85d1a53accd5dc27" + integrity sha512-8egDX8dE50XyXWH6C6PRCNkTP106DuUrvdrednFouDSmCi7IOvrqr0frznfZaHifHH/3aq/7a7v9N4wdXMqhBQ== + "@types/prop-types@*": version "15.7.4" resolved "https://registry.yarnpkg.com/@types/prop-types/-/prop-types-15.7.4.tgz#fcf7205c25dff795ee79af1e30da2c9790808f11" From 41179f6cb39749872303b3c416b094aafa26fa25 Mon Sep 17 00:00:00 2001 From: Kenichi Kamiya Date: Tue, 20 Jun 2023 19:40:56 +0900 Subject: [PATCH 4/4] Ignore major updating for types/node --- .github/dependabot.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index bd201b86..7719ec37 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -21,6 +21,9 @@ updates: open-pull-requests-limit: 10 labels: - automerge + ignore: + - dependency-name: '@types/node' + update-types: ['version-update:semver-major'] - package-ecosystem: gomod directory: "/hashira-web/functions" schedule: