Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: cache current time for workders and update it periodically #261

Merged
merged 3 commits into from Dec 11, 2022

Conversation

panjf2000
Copy link
Owner


name: Pull request
about: Propose changes to the code
title: ''
labels: ''
assignees: ''

1. Are you opening this pull request for bug-fixs, optimizations or new feature?

2. Please describe how these code changes achieve your intention.

3. Please link to the relevant issues (if any).

4. Which documentation changes (if any) need to be made/updated because of this PR?

4. Checklist

  • I have squashed all insignificant commits.
  • I have commented my code for explaining package types, values, functions, and non-obvious lines.
  • I have written unit tests and verified that all tests passes (if needed).
  • I have documented feature info on the README (only when this PR is adding a new feature).
  • (optional) I am willing to help maintain this change if there are issues with it later.

@github-actions github-actions bot added the enhancement New feature or request label Dec 11, 2022
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 92.58% // Head: 92.88% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (fc731bc) compared to base (668e945).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   92.58%   92.88%   +0.30%     
==========================================
  Files           9        9              
  Lines         728      759      +31     
==========================================
+ Hits          674      705      +31     
  Misses         41       41              
  Partials       13       13              
Flag Coverage Δ
unittests 92.88% <100.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ants.go 85.00% <ø> (ø)
pool.go 89.82% <100.00%> (+0.57%) ⬆️
pool_func.go 91.37% <100.00%> (+0.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@panjf2000 panjf2000 merged commit 3fbd956 into master Dec 11, 2022
@panjf2000 panjf2000 deleted the opt-perf branch December 11, 2022 11:50
@panjf2000
Copy link
Owner Author

Fixed #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant