Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to turn off automatically purge #253

Merged
merged 1 commit into from Oct 11, 2022

Conversation

czs007
Copy link
Contributor

@czs007 czs007 commented Sep 27, 2022

fix #252
Signed-off-by: zhenshan.cao zhenshan.cao@zilliz.com

ants_test.go Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
Copy link
Owner

@panjf2000 panjf2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comments, and also, implement this feature for PoolFunc.

@panjf2000 panjf2000 added the pending development Requested PR owner to improve code and waiting for the result label Sep 28, 2022
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
@czs007
Copy link
Contributor Author

czs007 commented Oct 11, 2022

@panjf2000 PTAL

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 92.46% // Head: 92.58% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (770b37b) compared to base (32664cb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   92.46%   92.58%   +0.11%     
==========================================
  Files           9        9              
  Lines         717      728      +11     
==========================================
+ Hits          663      674      +11     
  Misses         41       41              
  Partials       13       13              
Flag Coverage Δ
unittests 92.58% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
options.go 100.00% <100.00%> (ø)
pool.go 89.25% <100.00%> (+0.20%) ⬆️
pool_func.go 90.67% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@panjf2000 panjf2000 added the pending merged This PR has been reviewed and approved label Oct 11, 2022
@panjf2000 panjf2000 merged commit 8b106ab into panjf2000:master Oct 11, 2022
@panjf2000
Copy link
Owner

Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending development Requested PR owner to improve code and waiting for the result pending merged This PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to turn off purgePeriodically
2 participants