Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cupy to ml notebooks #322

Open
rabernat opened this issue Apr 29, 2022 · 3 comments
Open

Add cupy to ml notebooks #322

rabernat opened this issue Apr 29, 2022 · 3 comments

Comments

@rabernat
Copy link
Member

It should be easy to support cupy in both ml notebooks, no?

@ngam
Copy link
Contributor

ngam commented May 1, 2022

Should be easy, yes, though as you said in another thread, the ML notebooks/images should ideally be strictly anchored around a framework. For now, the current frameworks are tensorflow and pytorch. There will likely be pulling and shoving between the heavyweights if we keep adding stuff in. To keep it in line of pytorch--tensorflow separation, I would think having a RAPIDS image might be more sensible. As I mentioned in the latter part of this comment, I think following NGC containers may be the most sustainable in the future, though to be honest/clear, I have no idea what the larger scope of these images will be... so I could be misunderstanding things!

@ngam
Copy link
Contributor

ngam commented Jun 13, 2022

Adding cupy to #345

@weiji14
Copy link
Member

weiji14 commented Sep 13, 2022

There's been some interest at xarray-contrib/xbatcher#87 on having a GPU direct storage demo which uses cupy-xarray and kvikIO (a RAPIDS AI library), and it would be good to have a working docker image with CuPy (that can be readily deployed on some cloud provider) to showcase the functionality.

So, my question is: what's the conclusion of the experimental 'super-ml-notebook' docker container PRs at #345 (comment) and #369? Is the idea to:

  1. Have a single super-ml container with Pytorch+Tensorflow+CuPy, or
  2. Have 3 separate docker images (Pytorch, Tensorflow/JAX, RAPIDS/CuPy)?

Personally, I would vote for a separate docker image with CuPy, CuML, kvikIO, and other RAPIDS AI libraries, but I also acknowledge that having 3 separate ML docker images can be a maintenance burden as mentioned in #188. Still unsure if having a 3 in 1 image is any easier 😆, but wanted to hear people's thoughts on what's a good medium term (<1 year) plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants