Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Enforce Numpy Docstring Validation for pandas.IntervalIndex.mid #58657

Merged
merged 3 commits into from May 9, 2024

Conversation

tuhinsharma121
Copy link
Contributor

@tuhinsharma121 tuhinsharma121 commented May 9, 2024

fixes

pandas.IntervalIndex.mid GL08

and

pandas.IntervalIndex.right

return type in Examples

@tuhinsharma121 tuhinsharma121 marked this pull request as ready for review May 9, 2024 18:10
--------
>>> iv_idx = pd.IntervalIndex.from_arrays([1, 2, 3], [4, 5, 6])
>>> iv_idx.mid
Float64Index([2.5, 3.5, 4.5], dtype='float64')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a regular Index?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I wonder how the test passed. I see similar issue with the right method as well. Fixing both of them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the PR description.

@mroeschke mroeschke added the Docs label May 9, 2024
@mroeschke mroeschke added this to the 3.0 milestone May 9, 2024
@mroeschke mroeschke merged commit bae7965 into pandas-dev:main May 9, 2024
47 of 51 checks passed
@mroeschke
Copy link
Member

Thanks @tuhinsharma121

@tuhinsharma121 tuhinsharma121 deleted the np-doc-int-mid branch May 12, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants