Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sytle in stylesheet for <blockquote> #48770

Merged
merged 5 commits into from Oct 14, 2022

Conversation

Himanshuwagh
Copy link
Contributor

@Himanshuwagh Himanshuwagh commented Sep 25, 2022

Closes #48758

added styles for stylesheets for <blockquote> tag

  1. added left-padding
  2. also changed the font color ( default black to gray )

- screenshot of desktop

op1

- screenshot of mobile

op2

@datapythonista datapythonista added the Web pandas website label Sep 25, 2022
@datapythonista
Copy link
Member

Thanks for working on this @Himanshuwagh. Would be good if you can share a screenshot of how this looks in both desktop and mobile, so people can have feedback on that.

Also, if it makes sense, would be good to keep consistency on #ffffff vs rgb(255, 255, 255) or px vs em format. If you have a reason for using different ways it's fine, but otherwise would make things easy to maintain if things are consistent in my opinion.

@Himanshuwagh
Copy link
Contributor Author

Himanshuwagh commented Sep 27, 2022

@datapythonista can you help as to how to check changes on mobile version.
P.S : I have attached screenshot for desktop in description, also have made changes suggested ( #ffffff vs rgb(255, 255, 255) or px vs em format )

@datapythonista
Copy link
Member

If you're using Brave or Chrome (and probably other browsers), you can simply right click anywhere in the screen, select Inspect, and then you have a small icon of a phone in the top left of the panel that opens. With that you can easily simulate in mobile.

If you also include the nonrmal paragraphs around the blokquote in the screenshot that would be better, it'll make it clearer how things look like.

Thanks for all the work on this @Himanshuwagh

@Himanshuwagh
Copy link
Contributor Author

@datapythonista Thanks for help.
I have updated and attached screenshots for both (desktop + mobile). You can review it now.

@datapythonista
Copy link
Member

Thanks @Himanshuwagh this is great. I wonder if it'd look better if we remove the left margin, leave the line aligned with the text, and increase a bit the padding between the left line and the text. What do you think? No big deal, probably just a personal preference, but having both padding and margin looks a bit strange to me. Feel free to disagree if you think it's ok like it is now. Thanks!

@Himanshuwagh
Copy link
Contributor Author

Himanshuwagh commented Sep 29, 2022

Thanks @Himanshuwagh this is great. I wonder if it'd look better if we remove the left margin, leave the line aligned with the text, and increase a bit the padding between the left line and the text. What do you think? No big deal, probably just a personal preference, but having both padding and margin looks a bit strange to me. Feel free to disagree if you think it's ok like it is now. Thanks!

Yes, @datapythonista this looks good to me. Let me know if you suggested the same.

op4

@datapythonista
Copy link
Member

Yes, your screenshot is what I'd do. I'd probably have the same padding in the top and bottom of the gray box too. Having the padding much smaller in the top loos a bit strange to me.

@Himanshuwagh
Copy link
Contributor Author

@datapythonista updated sir
op5

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @Himanshuwagh, nice work!

@Himanshuwagh
Copy link
Contributor Author

Himanshuwagh commented Sep 30, 2022

Thanks @datapythonista for helping throughout. Next steps ? merge would taken care of ?

@datapythonista
Copy link
Member

Someone else from the team will double check and merge

@mroeschke mroeschke added this to the 1.5.1 milestone Oct 14, 2022
@mroeschke mroeschke merged commit fb19ddb into pandas-dev:main Oct 14, 2022
@mroeschke
Copy link
Member

Thanks @Himanshuwagh

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 14, 2022
phofl pushed a commit that referenced this pull request Oct 15, 2022
…ockquote>) (#49102)

Backport PR #48770: added sytle in stylesheet for <blockquote>

Co-authored-by: Himanshu Wagh <76431630+Himanshuwagh@users.noreply.github.com>
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
* added sytle in stylesheet for <blockquote>

* Update pandas.css

* Update pandas.css

* Update pandas.css

* Update pandas.css

Co-authored-by: himanshu_wagh <himanshu.w@fyle.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WEB: Add style for blockquote
4 participants