Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: dev docs left side has no line breaks #48605

Closed
rhshadrach opened this issue Sep 17, 2022 · 6 comments · Fixed by #48623
Closed

DOC: dev docs left side has no line breaks #48605

rhshadrach opened this issue Sep 17, 2022 · 6 comments · Fixed by #48623
Labels
Bug Docs Regression Functionality that used to work in a prior pandas version
Milestone

Comments

@rhshadrach
Copy link
Member

https://pandas.pydata.org/pandas-docs/dev/reference/index.html

I'm seeing:

image

I presume this will impact the release, tagging as 1.5. Haven't had a chance to investigate what happened.

@rhshadrach rhshadrach added Bug Docs Regression Functionality that used to work in a prior pandas version labels Sep 17, 2022
@rhshadrach rhshadrach added this to the 1.5 milestone Sep 17, 2022
@rhshadrach
Copy link
Member Author

rhshadrach commented Sep 17, 2022

Not sure if this is related, but there is also on odd checkbox appearing on certain pages:

https://pandas.pydata.org/pandas-docs/dev/reference/api/pandas.api.extensions.register_extension_dtype.html

image

@foram-chandra
Copy link

@rhshadrach I would like to give it a shot :)

@rhshadrach
Copy link
Member Author

rhshadrach commented Sep 18, 2022

I've verified that last built docs in #48285 have this issue (you can download the docs as an artifact from the docs build). Pinning back to pydata-sphinx-theme==0.9.0 and reverting the change to sidebar-nav-bs.html from that PR fixes the sidebar issues. I'm currently seeing if we can fix without the reverts.

cc @phofl

@rhshadrach
Copy link
Member Author

rhshadrach commented Sep 18, 2022

Thanks @foram-chandra! You're certainly welcome to, and please report any progress here or put up a PR. However, since this impacts the release scheduled for tomorrow, I (and possibly others) will be working on this in tandem.

@foram-chandra
Copy link

@rhshadrach thanks for replying back. Since it is a high priority issue and I am new to pandas, I will find another issue to work on :)

@rhshadrach
Copy link
Member Author

This issue seems to be sidebar-nav-bs.html; removing this file gives us the new pydata-sphinx-theme sidebar and a quick check looks great. Putting up a PR and doing more thorough checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Docs Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants