Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Fix unsigned pyarrow types in SIGNED_INT_PYARROW_DTYPES #48457

Merged
merged 28 commits into from Oct 14, 2022
Merged

TST: Fix unsigned pyarrow types in SIGNED_INT_PYARROW_DTYPES #48457

merged 28 commits into from Oct 14, 2022

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Sep 8, 2022 •
edited

@datapythonista
Copy link
Member

Thanks @gsheni, is there an issue for this? Can you please provide context about this?

@mroeschke
Copy link
Member

Thanks for the pull request, but when implementing this I did not specifically include testing pa.string() because pyarrow string functionality still fully exists in StringDtype("pyarrow") and ArrowStringArray. This note will be in the 1.5 docs: https://pandas.pydata.org/docs/dev/reference/arrays.html#pyarrow

What would be helpful is to start an issue to discuss whether there's interest to have ArrowDtype(pa.string()) replace StringDtype("pyarrow") in the future.

@gsheni gsheni mentioned this pull request Sep 8, 2022
Open
3 tasks
@gsheni
Copy link
Contributor Author

gsheni commented Sep 8, 2022

@mroeschke sure, issue created here: #48469

It might be worth reviewing this MR, as the SIGNED_INT_PYARROW_DTYPES list has incorrect data types.

@mroeschke
Copy link
Member

It might be worth reviewing this MR, as the SIGNED_INT_PYARROW_DTYPES list has incorrect data types.

Yes those fixes would be welcome!

@gsheni gsheni marked this pull request as ready for review September 8, 2022 18:32
@pep8speaks
Copy link

pep8speaks commented Sep 8, 2022 •
edited

Hello @gsheni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-09-12 22:05:40 UTC

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Arrow pyarrow functionality labels Sep 8, 2022
@mroeschke mroeschke changed the title Add to string dtypes to ALL_PYARROW_DTYPES TST: Fix unsigned pyarrow types in SIGNED_INT_PYARROW_DTYPES Sep 8, 2022
@mroeschke
Copy link
Member

@gsheni mind merging main? Don't remember if these failures were real or unrelated

@mroeschke
Copy link
Member

test_add_series_with_extension_array might need an xfail

@mroeschke mroeschke added this to the 1.5.1 milestone Oct 14, 2022
mroeschke
mroeschke approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Backporting as ArrowDtype support and testing was added in 1.5.

@mroeschke mroeschke merged commit ac3e26f into pandas-dev:main Oct 14, 2022
@mroeschke
Copy link
Member

Thanks @gsheni

@meeseeksmachine meeseeksmachine mentioned this pull request Oct 14, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 14, 2022
@gsheni @meeseeksmachine
Backport PR pandas-dev#48457: TST: Fix unsigned pyarrow types in SIGN…
eba00bf 
…ED_INT_PYARROW_DTYPES
@gsheni gsheni deleted the patch-1 branch October 14, 2022 18:15
phofl pushed a commit that referenced this pull request Oct 14, 2022
@meeseeksmachine @gsheni
Backport PR #48457 on branch 1.5.x (TST: Fix unsigned pyarrow types i…
c58f205 
…n SIGNED_INT_PYARROW_DTYPES) (#49093)

Backport PR #48457: TST: Fix unsigned pyarrow types in SIGNED_INT_PYARROW_DTYPES

Co-authored-by: Gaurav Sheni <gvsheni@gmail.com>
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@gsheni @mroeschke @noatamir
TST: Fix unsigned pyarrow types in SIGNED_INT_PYARROW_DTYPES (pandas-…
eab87af 
…dev#48457)

* Update __init__.py

* Update __init__.py

* Update __init__.py

* Update test_arrow.py

* Update test_arrow.py

* Update test_arrow.py

* Update test_arrow.py

* Update test_arrow.py

* Update test_arrow.py

* Update test_arrow.py

* Update test_arrow.py

* Update test_arrow.py

* Update test_arrow.py

* Update test_arrow.py

* Update test_arrow.py

* Update test_arrow.py

* Update test_arrow.py

* Update test_arrow.py

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.

BUG: The var SIGNED_INT_PYARROW_DTYPES has incorrect data types
4 participants
@gsheni @datapythonista @mroeschke @pep8speaks