Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG/REGR: Fix subset for DataFrameGroupBy.value_counts #48164

Merged
merged 5 commits into from Aug 23, 2022
Merged

BUG/REGR: Fix subset for DataFrameGroupBy.value_counts #48164

merged 5 commits into from Aug 23, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added Groupby Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff labels Aug 19, 2022
@mroeschke mroeschke added this to the 1.4.4 milestone Aug 19, 2022
phofl
phofl approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mroeschke mroeschke merged commit 606dd3c into pandas-dev:main Aug 23, 2022
@mroeschke mroeschke deleted the bug/gb_valuecounts/subset branch August 23, 2022 00:14
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 23, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 23, 2022
@mroeschke @meeseeksmachine
Backport PR pandas-dev#48164: BUG/REGR: Fix subset for DataFrameGroup…
94aec41 
…By.value_counts
phofl pushed a commit that referenced this pull request Aug 23, 2022
@meeseeksmachine @mroeschke
Backport PR #48164 on branch 1.4.x (BUG/REGR: Fix subset for DataFram…
2f71a9c 
…eGroupBy.value_counts) (#48204)

Backport PR #48164: BUG/REGR: Fix subset for DataFrameGroupBy.value_counts

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
simonjayhawkins
simonjayhawkins reviewed Aug 30, 2022
View reviewed changes
doc/source/whatsnew/v1.4.4.rst
@@ -37,6 +37,7 @@ Bug fixes
~~~~~~~~~
- The :class:`errors.FutureWarning` raised when passing arguments (other than ``filepath_or_buffer``) as positional in :func:`read_csv` is now raised at the correct stacklevel (:issue:`47385`)
- Bug in :meth:`DataFrame.to_sql` when ``method`` was a ``callable`` that did not return an ``int`` and would raise a ``TypeError`` (:issue:`46891`)
- Bug in :meth:`DataFrameGroupBy.value_counts` where ``subset`` had no effect (:issue:`44267`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be changing issue number to #46383 in #48314

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simonjayhawkins! Sounds good

noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@mroeschke @noatamir
BUG/REGR: Fix subset for DataFrameGroupBy.value_counts (pandas-dev#48164
de822ed 
)

* BUG/REGR: Fix subset for DataFrameGroupBy.value_counts

* Test subset not in columns; duplicate columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Groupby
Projects
None yet
Milestone
1.4.4
Development

Successfully merging this pull request may close these issues.

BUG: subset parameter of DataFrameGroupBy.value_counts has no effect
3 participants
@mroeschke @simonjayhawkins @phofl