REGR: unstack on 'int' dtype prevent fillna to work #38244
Merged
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Regression
simonjayhawkins
commented
Dec 2, 2020
|
|
||
| # This would raise `ValueError: Cannot convert non-finite values (NA or inf) | ||
| # to integer` if the fillna operation above fails | ||
| result[("is_", "ca")] = result[("is_", "ca")].astype("uint8") |
There was a problem hiding this comment.
This is from the op. but could do a explicit assert_frame_equal instead.
There was a problem hiding this comment.
yeah pls construct an expected frame and compare
jreback
requested changes
Dec 2, 2020
|
|
||
| # This would raise `ValueError: Cannot convert non-finite values (NA or inf) | ||
| # to integer` if the fillna operation above fails | ||
| result[("is_", "ca")] = result[("is_", "ca")].astype("uint8") |
There was a problem hiding this comment.
yeah pls construct an expected frame and compare
jreback
approved these changes
Dec 2, 2020
|
thanks @simonjayhawkins hopefuly will backport cleanly |
|
@meeseeksdev backport 1.1.x |
This comment has been minimized.
This comment has been minimized.
simonjayhawkins
added a commit
to simonjayhawkins/pandas
that referenced
this pull request
Dec 3, 2020
simonjayhawkins
added a commit
that referenced
this pull request
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff