Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in search results don't work. #42

Closed
janEntikan opened this issue Mar 4, 2020 · 2 comments
Closed

Links in search results don't work. #42

janEntikan opened this issue Mar 4, 2020 · 2 comments
Assignees

Comments

@janEntikan
Copy link
Contributor

None of the links in search results seem to work.

Steps to reproduce:

  1. Search for something
  2. Click on a result
@ArsThaumaturgis
Copy link

I just ran into this, too.

Specifically, it looks like the links produced by searches lack the "python"/"cpp" part of the URL. So, for example, the URL for the API entry on the "CollisionSphere" class looks like this:

https://docs.panda3d.org/1.10/python/reference/panda3d.core.CollisionSphere

While the URL returned by a search looks like this (omitting highlighting, etc.):

https://docs.panda3d.org/1.10/reference/panda3d.core.CollisionSphere.html

Note the lack of "python/" between "1.10/" and "reference/".

Link to a search that--for me, at least--produces such a broken result:
https://docs.panda3d.org/1.10/python/search?q=collisionsphere&check_keywords=yes&area=default

(This seems to hold true for both API and manual URLs.)

@rdb
Copy link
Member

rdb commented Mar 7, 2020

This is caused by an update in Sphinx, namely sphinx-doc/sphinx#7192, which changes search results to use absolute URLs instead of relative.

I think until this is changed back upstream, we'll just have to ship our own copy of searchtools.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants