Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle unclosed socket resource warning #2498

Merged
merged 1 commit into from Aug 8, 2022
Merged

handle unclosed socket resource warning #2498

merged 1 commit into from Aug 8, 2022

Conversation

davidism
Copy link
Member

@davidism davidism commented Aug 8, 2022

Call socket.detach on the socket prepared by run_simple. That object is not used, the server opens another with socket.fromfd. fromfd causes another ResourceWarning, but it's not clear that it's possible to address that one.

closes #2421

@davidism davidism added this to the 2.2.2 milestone Aug 8, 2022
@davidism davidism linked an issue Aug 8, 2022 that may be closed by this pull request
ResourceWarning for unclosed sockets with development server #2421
Closed
@davidism davidism merged commit 110b4cd into 2.2.x Aug 8, 2022
@davidism davidism deleted the socket-warning branch August 8, 2022 21:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
@davidism
Copy link
Member Author

Other warning addressed in #2517.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.

ResourceWarning for unclosed sockets with development server
1 participant
@davidism