s_maxage converts to an int

[Yourun-proger]

• fixes ResponseCacheControl.s_maxage raises error when set to an int #2364

Checklist:

• Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
• Add an entry in CHANGES.rst summarizing the change and linking to the issue.
• Add .. versionchanged:: entries in any relevant code docs.
• Run pre-commit hooks and fix any issues.
• Run pytest and tox, no tests failed.

[davidism]

This only addresses the specific attribute, there are others that have the same issue where type is set to None, and can be addressed at a higher level.

[Yourun-proger]

@davidism, thanks for reasonable remark! Indeed, it is better to do everything at once, and not to correct identical issues one by one.
I just looked and found such problems here:

• in ResponseCacheControl: field private (should be bool)
• in _CacheControl class: fields no_transform (should be bool) and no_cache (should also be bool)

There is nothing like it anywhere else. Do I understand correctly that tests should also be written for all this?

[Yourun-proger]

Oh. I've made all the necessary changes, but I'm not passing tests at this location:

         assert c.no_cache is None
         assert c.private is None

Because now these fields are by default casted to bool. And as you know, bool(None) is False.
Here's what should I do? Change these tests?

[davidism]

I'll figure out a way to deprecate the old behavior and transition to keys returning False or None if not set.

[Yourun-proger]

I deleted that comment, but still I didn't get it. Do I need to do anything with failing tests?

[davidism]

No, you're fine.

[Yourun-proger]

OK. Thanks a lot! I have been trying to implement this myself for the last couple of hours, but there are too many pitfalls in this case ...
I'll post the changes as soon as possible :3

[Yourun-proger]

Wow! I did not understand why git thinks that I changed so much in the docstrings, I just added info about 2.1.1