Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert HTTPException.description to string #2133

Merged
merged 1 commit into from May 17, 2021
Merged

Conversation

davidism
Copy link
Member

Allows HTTPDescription to be None again. Additionally allows it to be another object like a dict, which seems to a pattern that is used to pass structured information to turn into a JSON response. I'm not sure that's actually documented as supported, so I'm not changing the type annotations for now.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 2.0.1 milestone May 17, 2021
@davidism davidism merged commit e6305ec into 2.0.x May 17, 2021
@davidism davidism deleted the http-description branch May 17, 2021 22:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant