Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_dump_date zfills years < 4 digits #1740

Merged
merged 1 commit into from Mar 17, 2020
Merged

_dump_date zfills years < 4 digits #1740

merged 1 commit into from Mar 17, 2020

Conversation

nicolary
Copy link
Contributor

@nicolary nicolary commented Feb 25, 2020 •
edited by davidism

fixes #1739

Added a zfill to correctly display year on dates before year 1000.

@davidism davidism changed the base branch from master to 1.0.x February 25, 2020 20:39
@davidism davidism linked an issue Feb 25, 2020 that may be closed by this pull request
_dump_date year conversion doesn't zfill(4) #1739
Closed
@nicolary
Copy link
Contributor Author

Sorry I screwed up the base branch...

@nicolary nicolary marked this pull request as ready for review February 25, 2020 21:05
davidism
davidism reviewed Feb 25, 2020
View reviewed changes
tests/test_http.py Outdated Show resolved Hide resolved
@davidism davidism added this to the 1.0.1 milestone Feb 25, 2020
@davidism
Copy link
Member

Can you also add a changelog to the 1.0.1 section?

@nicolary
Copy link
Contributor Author

Hi - my tox run failed on "Job Python 3.8 Mac" with:

2020-02-26T00:35:31.7220500Z =================================== FAILURES ===================================
2020-02-26T00:35:31.7223060Z _______________________________ test_basic_local _______________________________
2020-02-26T00:35:31.7224700Z tests/test_local.py:36: in test_basic_local
2020-02-26T00:35:31.7226140Z     assert sorted(values) == [1, 2, 3]
2020-02-26T00:35:31.7226850Z E   assert [1, 3] == [1, 2, 3]
2020-02-26T00:35:31.7227430Z E     At index 1 diff: 3 != 2
2020-02-26T00:35:31.7229070Z E     Right contains one more item: 3
2020-02-26T00:35:31.7230290Z E     Use -v to get the full diff

This has nothing to do with my code additions - was it just a hiccup and the tests can be re-run?

@davidism
Copy link
Member

Yeah, those are just flaky tests, don't worry about that.

@nicolary
Copy link
Contributor Author

Ok - let me know if I need to do anything else. Thanks for the help.

@davidism davidism changed the title zfill 4 for _dump_date addressing issue #1739 _dump_date zfills years < 4 digits Mar 17, 2020
@davidism davidism merged commit 6ff5cd1 into pallets:1.0.x Mar 17, 2020
@nicolary
Copy link
Contributor Author

thank you for your service

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidism davidism davidism left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.

_dump_date year conversion doesn't zfill(4)
2 participants
@nicolary @davidism